chore(ci): pin runners to ubuntu-24.04 and run tests in CI - #50
Merged
Conversation
- Both workflows requested the retired ubuntu-20.04 hosted runner, so jobs hung at 'Waiting for a runner to pick up this job'. Pin both to ubuntu-24.04. - Split the CI 'Tests' step into 'Format check' + 'Test' (npm run test --if-present) so the Vitest parity suite runs in CI once present on a branch, and no-ops safely where absent. - Reformat the two workflow YAML files via Prettier. No source changes needed: under the pinned prettier 3.5.1 (same version CI installs), format-check already passes on main. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI jobs on the open PRs were stuck at "Waiting for a runner to pick up this job…" with
Requested labels: ubuntu-20.04. That hosted-runner image has been retired, so no runner ever picks the job up. This was the real (and only) CI blocker.Changes
runs-on: ubuntu-24.04in both.github/workflows/CI.ymlandbuild.yml(was the removedubuntu-20.04).Format checkstep and aTeststep usingnpm run test --if-present— so the Vitest parity suite runs once a branch has it, and is a safe no-op on branches/mainthat don't yet (e.g. before test: Vitest characterization harness + first jsfeat parity test (Phase 0) #49 merges). Keeps runner + format + test in one PR without breaking anything regardless of merge order.Notes for reviewer
prettier@3.5.1(the exact version CI installs from the lockfile),format-checkalready passes onmain. An earlier assumption that ~8 files had Prettier debt was a false alarm from a transiently-resolved different prettier during a dep install.ubuntu-24.04) rather than hang — so this PR's own checks validate the fix.npm testwill then run green in CI), then docs: jsfeat parity/refactor audit plan + cross-agent instructions #48.🤖 Generated with Claude Code