Static-image Teblid AR example (#30) + WebARKitLib pose/localization fixes - #35
Merged
Conversation
Pick up the WebARKitLib fixes and rebuild the WASM/dist artifacts: scale-factor double-application (webarkit/WebARKitLib#43), projection X-sign and D*R*D marker-frame handedness (webarkit/WebARKitLib#35, webarkit/WebARKitLib#42). The static-image example now tracks the pinball marker with content correctly localized on the marker and right-side-up (X=right, Y=up, Z=toward viewer), no example-side pose correction. - bump emscripten/WebARKitLib submodule (9eb49d9, 3a9c58a) - rebuild build/webarkit_ES6_wasm.js, .simd.js, dist/WebARKit.js - examples/threejs_static_image_worker_ES6.js: drop debug scaffolding; attach cube + axes directly to the tracked root Refs #30 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Rewrite the design doc's resolution: the static-image AR bug was three orthogonal issues, headlined by the keypoint scale-factor double-application (webarkit/WebARKitLib#43), plus the projection X-sign (#35) and D*R*D marker-frame handedness (#42). Documents the diagnostic method (MATCH-centroid log, getCorners debug overlay, pose-log NDC math) and the final verified state. Demotes the superseded hypotheses (projection-only #35 plan, GrayScale Y-flip theory, example-side correction) to a clearly-marked history section. Refs #30, webarkit/WebARKitLib#35, webarkit/WebARKitLib#42, webarkit/WebARKitLib#43 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Pick up webarkit/WebARKitLib refactor fb78f85 (remove vestigial downsample/scale machinery; no behavior change) and rebuild build/ + dist/. Refs #30, webarkit/WebARKitLib#43, webarkit/WebARKitLib#44 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
3 tasks
3 tasks
webarkit/WebARKitLib#45 merged into dev (rebased to 1021616, f448ef3, c1ae096). Re-point the submodule from the fork branch commit to the canonical dev tip. Source is identical, so build/ and dist/ are unchanged. Refs #30, webarkit/WebARKitLib#45 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kalwalt
added a commit
that referenced
this pull request
Jun 10, 2026
Rewrite the design doc's resolution: the static-image AR bug was three orthogonal issues, headlined by the keypoint scale-factor double-application (webarkit/WebARKitLib#43), plus the projection X-sign (#35) and D*R*D marker-frame handedness (#42). Documents the diagnostic method (MATCH-centroid log, getCorners debug overlay, pose-log NDC math) and the final verified state. Demotes the superseded hypotheses (projection-only #35 plan, GrayScale Y-flip theory, example-side correction) to a clearly-marked history section. Refs #30, webarkit/WebARKitLib#35, webarkit/WebARKitLib#42, webarkit/WebARKitLib#43 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kalwalt
added a commit
that referenced
this pull request
Jun 21, 2026
Rewrite the design doc's resolution: the static-image AR bug was three orthogonal issues, headlined by the keypoint scale-factor double-application (webarkit/WebARKitLib#43), plus the projection X-sign (#35) and D*R*D marker-frame handedness (#42). Documents the diagnostic method (MATCH-centroid log, getCorners debug overlay, pose-log NDC math) and the final verified state. Demotes the superseded hypotheses (projection-only #35 plan, GrayScale Y-flip theory, example-side correction) to a clearly-marked history section. Refs #30, webarkit/WebARKitLib#35, webarkit/WebARKitLib#42, webarkit/WebARKitLib#43 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the static-image Teblid AR example (#30) and picks up the WebARKitLib fixes that make it render correctly. The example tracks the pinball marker in a still image (
data/pinball-demo.jpg) and renders a cube + axes correctly localized and oriented on the marker.Depends on webarkit/WebARKitLib#45 (bundled here via the submodule bump + rebuilt
build/anddist/).What's included
examples/threejs_teblid_static_image_ES6_example.html+examples/threejs_static_image_worker_ES6.js— the static-image example (cube + axes attached directly to the tracked root; no example-side pose correction).emscripten/WebARKitLibto the pose/localization fixes.build/webarkit_ES6_wasm.js,build/webarkit_ES6_wasm.simd.js,dist/WebARKit.js.docs/design-projection-and-pose-artoolkitx-alignment.md— rewritten with the actual root cause and the diagnostic method (the older DRD-only / GrayScale theories are demoted to a clearly-marked history section).The fixes (in WebARKitLib#45)
Three orthogonal bugs presented as one "mirror":
Follow-up perf work: webarkit/WebARKitLib#44.
Testing
Manual/visual on the static-image example (2000x1500): debug overlay confirmed the detected marker quad sits tightly on the pinball panel; cube + axes anchor at the marker origin, right-handed (red→right, green→up, blue→toward viewer). Diagnostics were removed after verification.
Review checklist
data/pinball.jpg(marker) +data/pinball-demo.jpg(scene) correctlyCloses #30
🤖 Generated with Claude Code