docs(#50): dead / duplicated / orphan code inventory - #44
Merged
Conversation
Manual cross-repo (C++ + JS/bindings) dead-code inventory for WebARKitLib#50, audited at submodule 28ff065. Inventory only -- no code removed. Key outcomes: - All seven named suspects resolved; matrix getters classified as intentional public API (keep), with getPoseMatrix/getPoseMatrix2 -> getPoseMatrixCV/ getPoseMatrixGL rename + the getPoseMatrix zero-matrix fix tracked in #55. - Confirmed-dead internal/redundant code enumerated per file with a master cleanup decision table (KEEP-API / KEEP-live / REMOVE-redundant / REMOVE-internal / FIX / DECIDE). - _trackVizActive / TrackerVisualization flagged DECIDE (unreachable, no setter). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
4 tasks
kalwalt
added a commit
that referenced
this pull request
Jun 21, 2026
…xample Bump WebARKitLib to the part-A downsampling change (webarkit/WebARKitLib#52) and rebuild build/ + dist/. Feature detection now runs on a pyrDown'd copy of the live frame; matched keypoints are rescaled to full-frame coords. - examples: point the Teblid static-image example at a marker-fills-frame 1920x1440 demo image (pinball-demo-big.jpg) so HD downsampling is exercised (pyrLevel 1, scale 2.0) and the marker still acquires. The old pinball-demo.jpg (small marker in a large frame) falls below the detector threshold once downsampled. - docs: add docs/design-detection-downsampling.md (understanding, ArtoolkitX reference, decision log, the four edits, testing, risks, non-goals). Verified: Marker tracked, 1000 matches, content centered (#38) and right-handed (#42/#46), no #43-style doubling. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
kalwalt
added a commit
that referenced
this pull request
Jun 21, 2026
Bump WebARKitLib to the part-B detection guard (webarkit/WebARKitLib#54) and rebuild build/ + dist/. Feature detection is now skipped while optical flow holds a lock, so the steady tracking state is much cheaper. Measured on the Teblid webcam example (640x480): ~10-15 fps when detecting every frame -> ~45 fps while tracking. Static example (1920x1440, pyrLevel 1) still acquires and holds (no freeze). - docs: add docs/design-detection-guard.md (understanding, ArtoolkitX reference, why the guard is on _isTracking rather than the marker counter, state walk-through, testing, risks, non-goals). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inventory deliverable for WebARKitLib#50. Doc only — no code removed. Removals happen in later PRs, each verified (recompile + examples track).
What
docs/audit-dead-code-issue50.md— a manual, cross-repo (C++ + JS/bindings) dead/duplicated/orphan-code inventory, audited at submodule28ff065. Per-file findings + a master cleanup decision table (KEEP-API / KEEP-live / REMOVE-redundant / REMOVE-internal / FIX / DECIDE).Highlights
process_raw/processFrameare not a duplicate (public entry vs internal helper).matrixGL_RH.getPoseMatrix()returns a zero matrix (pose3dnever populated in the live path) — filed as getPoseMatrix() returns a zero matrix — pose3d is never populated in the live path WebARKitLib#55, with the agreedgetPoseMatrix/getPoseMatrix2→getPoseMatrixCV/getPoseMatrixGLrename riding along the fix._trackVizActive/TrackerVisualizationis unreachable (no setter) → flagged DECIDE (wire a toggle or remove).computePose/invertPose/pose3dcluster + its orphanedpoints2d/points3dinputs,getWebARKitVersion,getTracker,update()(declared, never defined), the cv::MatinitTracker/arglCameraViewRHfoverloads,getDistortionCoefficients,GetAllFeatures/CleanUp,inlier_matches,TrackedPoint::IsSelected/markerRoi,grayscale()/im_gray()/webarkitGetVersion(char**), and dead constantsN/featureDetectPyramidLevel/ theVERSION_MAJOR/MINOR/TINY/DEVquartet.makem.js+webpack.config.jsare clean — no orphans.Coverage
Full xref on Manager, Pattern, GL, Camera, Config, TrackingPointSelector, HomographyInfo, TrackedPoint, Utils, Enums, the whole JS/glue/examples chain, and the active paths of
WebARKitTracker.cpp. Low-risk spot-check remaining:WebARKitLogand individualpackage.jsonscripts.🤖 Generated with Claude Code