Uh oh!
There was an error while loading. Please reload this page.
feat(WebexMember): split component into space members and meeting participant - #772
feat(WebexMember): split component into space members and meeting participant#772thescripted wants to merge 2 commits into
Conversation
473bc67 to
78b320fCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
f1a0714 to
6991e6eCompare6991e6e to
6827327Comparecipak
commented
Apr 27, 2022
This seems to introduce some code duplication, can this be avoided? For example, leaving the generic WebexMember component as-is, and introducing two additional components:
These components would just use WebexMember with a hardcoded destination type, avoiding of duplication of js code and css: functionWebexSpaceMember(...){return<WebexMemberdestinationType="ROOM".../>;
}Maybe the same could be done for the roster. I would suggest using the names WebexSpaceRoster and WebexMeetingRoster, so that the difference is clear: |
Separate
WebexMemberintoWebexMemberfor spaces andWebexMeetingParticipantfor meetingsSeparate
WebexMemberRosterintoWebexMemberRosterfor spaces andWebexMeetingRosterfor meetingsSPARK-308491
SPARK-308492