Skip to content

feat(widgets): test e2e - #706

Open
riteshfyi wants to merge 6 commits into
webex:nextfrom
riteshfyi:teste2e
Open

feat(widgets): test e2e#706
riteshfyi wants to merge 6 commits into
webex:nextfrom
riteshfyi:teste2e

Conversation

@riteshfyi

Copy link
Copy Markdown
Contributor

COMPLETES #NA

This pull request addresses

This is a dummy pr to verify some download of browser download related issue in e2e.

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

@riteshfyi
riteshfyi requested a review from a team as a code ownerJune 24, 2026 06:37
@riteshfyiriteshfyi added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Jun 24, 2026
@riteshfyiriteshfyi changed the title feat: test e2efeat(widgets): test e2eJun 24, 2026
@aws-amplify-us-east-2

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-706.d1b38q61t1z947.amplifyapp.com

@github-actionsgithub-actionsBot removed the validated Indicates that the PR is ready for actions label Jun 24, 2026
@riteshfyiriteshfyi added the validated Indicates that the PR is ready for actions label Jun 24, 2026

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:52464d3444

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment threadpackage.json Outdated
"@babel/plugin-transform-runtime": "^7.29.0",
"@babel/preset-typescript": "7.25.9",
"@playwright/test": "^1.51.1",
"@playwright/test": "^1.60.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Commit the matching lockfile update

With this manifest change, the checked-in yarn.lock still records the root workspace dependency as @playwright/test: npm:^1.51.1 resolving to 1.51.1, so the new ^1.60.0 range cannot be satisfied from the lockfile. I checked .github/workflows/deploy.yml, which runs yarn install --immutable on dependency-cache misses, and local Yarn help says --immutable aborts when the lockfile would be modified; this will fail CI in that path, or leave e2e jobs using the old Playwright version until the lockfile is regenerated.

Useful? React with 👍 / 👎.

@github-actionsgithub-actionsBot removed the validated Indicates that the PR is ready for actions label Jun 24, 2026
@riteshfyiriteshfyi added the validated Indicates that the PR is ready for actions label Jun 24, 2026
@github-actionsgithub-actionsBot removed the validated Indicates that the PR is ready for actions label Jun 24, 2026
@riteshfyiriteshfyi added validated Indicates that the PR is ready for actions and removed validated Indicates that the PR is ready for actions labels Jun 24, 2026
@github-actionsgithub-actionsBot removed the validated Indicates that the PR is ready for actions label Jun 24, 2026
@riteshfyiriteshfyi added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets and removed validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Jun 24, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_e2eAdd this label to run E2E test for meeting and CC widgetsvalidatedIndicates that the PR is ready for actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@riteshfyi