Uh oh!
There was an error while loading. Please reload this page.
fix: install Xdebug in CI so header assertions run - #18
Merged
Conversation
The `test` job on main was failing with 8 errors. `CookieTest`, `RequestTest` and `ResponseTest` assert on sent headers via `xdebug_get_headers()`, but CI installed pcov, so the function was undefined. Switched `coverage` to `xdebug` and set `xdebug.mode="develop,coverage"`. Note: two assertion failures in this suite (`961 is identical to 953` and a string mismatch) were downstream of the missing headers; this PR verifies whether they clear once Xdebug is present. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Follow-up on the CI fix branch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testjob on main was failing with 8 errors.CookieTest,RequestTestandResponseTestassert on sent headers viaxdebug_get_headers(), but CI installed pcov, so the function was undefined. Switchedcoveragetoxdebugand setxdebug.mode="develop,coverage".Note: two assertion failures in this suite (
961 is identical to 953and a string mismatch) were downstream of the missing headers; this PR verifies whether they clear once Xdebug is present.🤖 Generated with Claude Code