Skip to content

Add support for using the TensorFlow.js WebGPU backend - #190

Open
reillyeon wants to merge 3 commits into
webmachinelearning:masterfrom
reillyeon:webgpu
Open

Add support for using the TensorFlow.js WebGPU backend#190
reillyeon wants to merge 3 commits into
webmachinelearning:masterfrom
reillyeon:webgpu

Conversation

@reillyeon

@reillyeonreillyeon commented Nov 11, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@reillyeon

reillyeon commented Nov 11, 2023

Copy link
Copy Markdown
ContributorAuthor

@huningxin, @BruceDai, @Honry, please take a look.

huningxin
huningxin approved these changes Nov 11, 2023
View reviewed changes

@huningxinhuningxin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits, thanks!

Comment threadcommon/utils.js Outdated
Comment threadfacial_landmark_detection/index.html Outdated
@reillyeon

reillyeon commented Nov 11, 2023

Copy link
Copy Markdown
ContributorAuthor

I'm sorry, I somehow accidentally pushed this PR based on an unfinished version of this patch. I will update with the final version later.

@reillyeon

reillyeon commented Nov 11, 2023

Copy link
Copy Markdown
ContributorAuthor

Please take another look.

huningxin
huningxin approved these changes Nov 11, 2023
View reviewed changes

@huningxinhuningxin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Honry
Honry approved these changes Nov 13, 2023
View reviewed changes

@HonryHonry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! While I will suspend this PR util the webnn-polyfill enables webgpu backend. (webmachinelearning/webnn-polyfill#192)

@reillyeon

reillyeon commented Nov 14, 2023

Copy link
Copy Markdown
ContributorAuthor

That isn't strictly necessary. I found that at least some of the demos work using the older WebGPU backend.

@Honry

Honry commented Nov 14, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

@reillyeon, oddly, I tested most samples with current WebGPU backend (older one), no one works expectedly.
e.g.

image

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huningxinhuningxinhuningxin approved these changes
@HonryHonryHonry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reillyeon@Honry@huningxin