Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Dec 17, 2025. It is now read-only.
Feature/get loader config - #23
Merged
Merged
Conversation
Unifies the way how configs are provided to loaders.
bebraw
commented
Feb 16, 2016
This seems like a cool idea. Obviously the main handicap is that we'll need to convince loader authors to adopt the API. But I guess there's no other way: 👍 |
jhnns
commented
Feb 16, 2016
ContributorAuthor
Yep, but the good thing is that it's not a breaking change. Things will just work for all other users. |
| assert.deepEqual(config, {slices:8}); | ||
| }); | ||
| it("should throw an error if the default config key is missing", function () { | ||
| assert.throws(function () { |
jhnns
commented
Feb 25, 2016
ContributorAuthor
Is this PR obsolete with webpack 2? |
jhnns
commented
Apr 10, 2016
ContributorAuthor
Thx @sokra. Do you think that this is obsolete with webpack2? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there are several loaders (less-loader, sass-loader, html-loader, markdown-loader) that accept "programmable" options like functions, regexes, etc. that are hard/impossible to stringify.
The
getLoaderConfigunifies the way how configs are provided to loaders by first trying to read the options from thewebpack.config.jsunder the given property key. After that, query options are merged into the object.getLoaderConfigis described as the recommended way to retrieve the config in the README. After maintaining several loaders, I think we should encourage the users to put their loader configs on thewebpack.config.js. Do you agree? @webpack/collab-team @sokra @webpack/html-loader-teamPlease give feedback before merging this in.