Uh oh!
There was an error while loading. Please reload this page.
Add workaround for sockjs@~0.3.19 - #1608
Conversation
sockjs will remove Origin header, however Origin header is required for checking host. This workaround maybe broken at sockjs@^0.14.x because of refactoring.
3846masa
commented
Dec 22, 2018
I'll fix code style. sorry |
Codecov Report
@@ Coverage Diff @@## master #1608 +/- ##
==========================================
- Coverage 74.25% 73.93% -0.33%
==========================================
Files 10 10 Lines 672 679 +7 ==========================================
+ Hits 499 502 +3 - Misses 173 177 +4
Continue to review full report at Codecov.
|
lbogdan
commented
Dec 22, 2018
Re: PR title, it's |
lbogdan
commented
Dec 22, 2018
I can confirm this fixes the websocket origin checking issue with projects created by |
alexander-akait
commented
Dec 22, 2018
@lbogdan Thanks! |
DannyFeliz
commented
Dec 23, 2018
Yes, this definitely fixes the issue. |
anchengjian
commented
Dec 23, 2018
It's working for me, @3846masa thanks |
rafamp85
commented
Dec 24, 2018
Good night everybody, I don't know how to apply this workaround in my Angular project, what do I have to do. BR |
bradharms
commented
Dec 31, 2018
It seems like I'm still getting this even after installing |
Also still getting this error with 3.1.14 & |
rcapile
commented
Jul 24, 2020
Also still getting this error with 3.1.14 & symfony proxy. I solved with Encore.configureDevServerOptions(options=>{options.allowedHosts=['my-domain.wip']}) |
For Bugs and Features; did you add new tests?
No
Motivation / Use-Case
sockjs will remove
Originheader, however Origin header is required for checking host (#1603).See #1604 (comment)
This workaround overwrote
Session.prototype.decorateConnection.(See https://github.com/sockjs/sockjs-node/blob/v0.3.19/src/transport.coffee#L112-L140)
Breaking Changes
Additional Info
This workaround maybe broken at
sockjs@^0.4.xbecause sockjs are refactoring now.When sockjs/sockjs-node#247 is merged, this workaround is not necessary.