Uh oh!
There was an error while loading. Please reload this page.
Check origin header for websocket connection - #1626
Conversation
hiroppy
commented
Feb 14, 2019
@Timsly please sign 👆 |
alexander-akait
commented
Feb 14, 2019
Tests failed, need fix |
timfjord
commented
Feb 14, 2019
@hiroppy Done, signed |
alexander-akait
commented
Feb 14, 2019
Yep, expected, we can merge this and release, don't have access for computer right now |
timfjord
commented
Feb 14, 2019
That would be great |
hiroppy
commented
Mar 5, 2019
rebuild https://ci.appveyor.com/project/sokra/webpack-dev-server @Timsly Could you rebase from master? |
timfjord
commented
Mar 6, 2019
@hiroppy I cannot rebase from |
alexander-akait
commented
Mar 6, 2019
timfjord
commented
Mar 6, 2019
Hm, in this case, I will cherry-pick them here |
@evilebottnawi I've ported both fixes, see f6c6af6 and ff8b19c |
alexander-akait
commented
Mar 13, 2019
@Timsly we don't have tests for |
timfjord
commented
Mar 22, 2019
@evilebottnawi I've tested current version and it works fine. |
timfjord
commented
Mar 22, 2019
@evilebottnawi is there a chance that this will be released as |
alexander-akait
commented
Mar 22, 2019
@Timsly today |
timfjord
commented
Mar 22, 2019
Thanks |
| // if hostHeader doesn't have scheme, add // for parsing. | ||
| /^(.+:)?\/\//.test(hostHeader) ? hostHeader : `//${hostHeader}`, | ||
| false, | ||
| true, |

For Bugs and Features; did you add new tests?
No
Motivation / Use-Case
This is a port of #1603 fix but for v2 branch.
Basically, it addresses CVE vulnerability https://www.npmjs.com/advisories/725
I know that v2 is deprecated but it is not an easy task to upgrade this lib to v3 in rails apps, because some dependencies are still in release candidate state or even in beta.
Breaking Changes
Websocket is now checked for origin
Additional Info