Uh oh!
There was an error while loading. Please reload this page.
Feature: add --stdin as an option in webpack.config.js - #1767
Conversation
Codecov Report
@@ Coverage Diff @@## master #1767 +/- ##
==========================================
- Coverage 92.52% 88.34% -4.18%
==========================================
Files 28 14 -14 Lines 1083 815 -268 Branches 324 258 -66 ==========================================
- Hits 1002 720 -282 - Misses 77 82 +5 - Partials 4 13 +9
Continue to review full report at Codecov.
|
hiroppy
left a comment
There was a problem hiding this comment.
Need to add stdin to errorMessage.
I don't know this option( |
EslamHiko
commented
Apr 7, 2019
@hiroppy Done |
alexander-akait
left a comment
There was a problem hiding this comment.
Looks good, we need add tests
EslamHiko
commented
Apr 8, 2019
@evilebottnawi I searched a lot & tried a lot to capture any input but I couldn't find a way to test if the CLI can accept input or not.
|
EslamHiko
commented
Sep 25, 2019
Closed for : #2186 |
alexander-akait
commented
Sep 25, 2019
@EslamHiko you send many PRs to webpack-dev-server, i think we can invite your as contributor, do you want to continue help use? |
EslamHiko
commented
Sep 25, 2019
@evilebottnawi Yes, sure I want to continue helping. |
alexander-akait
commented
Sep 25, 2019
@EslamHiko now you are member 🎉 |
For Bugs and Features; did you add new tests?
Test already exist 'should exit the process when SIGINT is detected' test in CLI.test
Motivation / Use-Case
solve these issues : webpack/webpack-cli#789 , #1712
Breaking Changes
No
Additional Info
Minimum reproducible repo : https://github.com/EslamHiko/webpack-dev-server/tree/add-stdin-option
go to examples/cli/stdin and add that config :
Run
npm run webpack-dev-serverwithout--stdinflagThe server will accept input and closes when you exit CTRL+C/CTRL+D the same behavior when you add
--stdinflagif you don't add the option and run
npm run webpack-dev-serverwithout--stdinit won't accept input