Skip to content

Feature/fix tests - #1997

Merged
hiroppy merged 1 commit into
nextfrom
feature/fix-next
Jun 8, 2019
Merged

Feature/fix tests#1997
hiroppy merged 1 commit into
nextfrom
feature/fix-next

Conversation

@hiroppy

Copy link
Copy Markdown
Contributor
  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

modify only

Motivation / Use-Case

fix tests of master.

Breaking Changes

no

Additional Info

@codecov

codecovBot commented Jun 8, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1997 into next will increase coverage by 0.67%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## next #1997 +/- ##
=========================================
+ Coverage 91.73% 92.4% +0.67% 
=========================================
Files 24 28 +4 Lines 1004 1067 +63 Branches 297 324 +27 =========================================
+ Hits 921 986 +65 + Misses 79 77 -2 
Partials 4 4
Impacted FilesCoverage Δ
client-src/clients/BaseClient.js33.33% <ø> (ø)⬆️
client-src/clients/SockJSClient.js86.66% <ø> (ø)⬆️
client-src/default/utils/createSocketUrl.js100% <0%> (ø)
client-src/default/utils/sendMessage.js83.33% <0%> (ø)
client-src/default/utils/reloadApp.js100% <0%> (ø)
client-src/default/utils/getCurrentScriptSource.js100% <0%> (ø)
lib/utils/runOpen.js100% <0%> (+30%)⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe1a4f...c58e498. Read the comment docs.

@hiroppy

Copy link
Copy Markdown
ContributorAuthor

This pr is to resolve lint and tests, and we cannot continue to work from next branch if we don't merge this. I'll merge this. /cc @evilebottnawi

@hiroppy
hiroppy merged commit 4558b1e into nextJun 8, 2019
@hiroppy
hiroppy deleted the feature/fix-next branch June 8, 2019 11:46
@alexander-akait

Copy link
Copy Markdown
Member

👍

hiroppy added a commit that referenced this pull request Jun 10, 2019
hiroppy added a commit that referenced this pull request Jun 15, 2019
hiroppy added a commit that referenced this pull request Jun 15, 2019
hiroppy added a commit that referenced this pull request Jun 15, 2019
hiroppy added a commit that referenced this pull request Jun 15, 2019
hiroppy added a commit that referenced this pull request Jun 24, 2019
hiroppy added a commit that referenced this pull request Jun 24, 2019
knagaitsev pushed a commit to knagaitsev/webpack-dev-server that referenced this pull request Jul 31, 2019
hiroppy added a commit that referenced this pull request Aug 1, 2019
hiroppy added a commit that referenced this pull request Aug 2, 2019
hiroppy added a commit that referenced this pull request Aug 5, 2019
hiroppy added a commit that referenced this pull request Sep 10, 2019
hiroppy added a commit that referenced this pull request Dec 12, 2019
hiroppy added a commit that referenced this pull request Dec 18, 2019
hiroppy added a commit that referenced this pull request Dec 19, 2019
hiroppy added a commit that referenced this pull request Dec 23, 2019
hiroppy added a commit that referenced this pull request Dec 24, 2019
alexander-akait pushed a commit that referenced this pull request Jan 29, 2020
alexander-akait pushed a commit that referenced this pull request Jan 31, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hiroppy@alexander-akait