fix(open): set wait: false to run server.close successfully

[hiroppy]

fixes: #1990

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

see #1990

commit: sindresorhus/open@da2d663#diff-168726dbe96b3ce427e7fedce31bb0bcR23

Our open(opn)'s version is old, and wait seems to be true by default in this version.

Breaking Changes

no

Additional Info

[alexander-akait]

Good catch 👍

[codecov]

Codecov Report

Merging #2001 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## master #2001 +/- ##
=======================================
Coverage 92.77% 92.77% =======================================
Files 29 29 Lines 1149 1149 Branches 327 327 =======================================
Hits 1066 1066 Misses 79 79 Partials 4 4

Impacted Files	Coverage Δ
lib/utils/runOpen.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90d4a7c...eb3fce5. Read the comment docs.

[hiroppy]

@evilebottnawi I added one commit(fdc6d31). PTAL

[alexander-akait]

No need modify object, it is really bad practice

[alexander-akait]

letopenOptions={wait: false};// ...if(typeofoptions.open==='string'){openOptions=Object.assign({}openOptions,{app: options.open});}

No need modify openOptions variable, it is very bad practice

[hiroppy]

openOptions = Object.assign({} openOptions, { app: options.open }); equals Object.assign(openOptions, { app: options.open }).

I don't think this is a very bad practice.

[alexander-akait]

Yes, but it is not good, we modify original object and it is bad practice because you can forget about this in future and it is lead to some problems when you refactor code.

When you pass options to third party package(s) better always cloning object. Other package can modify object too so it can lead to very strange errors and situations.

[hiroppy]

When you pass options to third party package(s) better always cloning object. Other package can modify object too so it can lead to very strange errors and situations.

If you say, we should not assign to the same variable.

I don't have any strong opinions, so I'll change.

[hiroppy]

@evilebottnawi PTAL

[alexander-akait]

Good work!