Skip to content

test: don't use --runInBand and improve execution performance - #2007

Merged
hiroppy merged 1 commit into
masterfrom
feature/modify-jest-backport
Jun 10, 2019
Merged

test: don't use --runInBand and improve execution performance#2007
hiroppy merged 1 commit into
masterfrom
feature/modify-jest-backport

Conversation

@hiroppy

Copy link
Copy Markdown
Contributor

backport from #2005 to master branch

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

modify only

Motivation / Use-Case

see #2005

Breaking Changes

no

Additional Info

@hiroppyhiroppy changed the title test: don't use --runInBand and improve execution performancetest: don't use --runInBand and improve execution performance(backport from next)Jun 10, 2019
@codecov

codecovBot commented Jun 10, 2019

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@2b4cb52). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #2007 +/- ##
=========================================
Coverage ? 92.77% =========================================
Files ? 29 Lines ? 1149 Branches ? 327 =========================================
Hits ? 1066 Misses ? 79 Partials ? 4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4cb52...bfbf543. Read the comment docs.

alexander-akait
alexander-akait previously approved these changes Jun 10, 2019

@alexander-akaitalexander-akait left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Feel free to merge when CI will be greean

@hiroppy

Copy link
Copy Markdown
ContributorAuthor

I'll change the setup code because Node6 doesn't support Object.entries.

@hiroppy

Copy link
Copy Markdown
ContributorAuthor

@evilebottnawi PTAL

@alexander-akait

Copy link
Copy Markdown
Member

Something wrong with CI and need resolve conflict

@hiroppy
hiroppyforce-pushed the feature/modify-jest-backport branch from 8be7932 to bfbf543CompareJune 10, 2019 14:25
@hiroppy

Copy link
Copy Markdown
ContributorAuthor

Resolved

@hiroppyhiroppy mentioned this pull request Jun 10, 2019
6 tasks
@hiroppyhiroppy changed the title test: don't use --runInBand and improve execution performance(backport from next)test: don't use --runInBand and improve execution performanceJun 10, 2019
@hiroppy
hiroppy merged commit 4dec6b2 into masterJun 10, 2019
@hiroppy
hiroppy deleted the feature/modify-jest-backport branch June 10, 2019 14:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hiroppy@alexander-akait