Uh oh!
There was an error while loading. Please reload this page.
fix(client): default client fallback with redirection to all default directory files - #2049
fix(client): default client fallback with redirection to all default directory files#2049knagaitsev wants to merge 3 commits into
Conversation
Codecov Report
@@ Coverage Diff @@## master #2049 +/- ##
==========================================
- Coverage 92.77% 92.11% -0.67%
==========================================
Files 29 20 -9 Lines 1149 875 -274 Branches 327 273 -54 ==========================================
- Hits 1066 806 -260 + Misses 79 66 -13 + Partials 4 3 -1Continue to review full report at Codecov.
|
knagaitsev
commented
Jun 18, 2019
@evilebottnawi@hiroppy Here is a fix. If you revert the previous fix, I will just rebase and fix any problems that result from that. |
knagaitsev
commented
Jun 19, 2019
Also I should add tests to make sure all the redirection are correct. Would it make more sense if |
The change I just made makes the This fix spans more than I expected, but probably is safer than other solutions. Edit: Just to explain more, I changed the tests so that the test mocks will mock the files in the |
knagaitsev
commented
Jun 29, 2019
Closing in favor of #2069 |
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Fix#2006,
Fix problems introduced by #2015
I made a redirect to each file in the
defaultdirectory, because it's better to be safe I think.Breaking Changes
None
Additional Info