Uh oh!
There was an error while loading. Please reload this page.
fix(server): stricter headers security check - #2092
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## master #2092 +/- ##
==========================================
+ Coverage 94.45% 94.46% +<.01%
==========================================
Files 32 32 Lines 1208 1210 +2 Branches 333 334 +1 ==========================================
+ Hits 1141 1143 +2
Misses 65 65 Partials 2 2
Continue to review full report at Codecov.
|
alexander-akait
approved these changes
Jul 2, 2019
alexander-akait
left a comment
Member
There was a problem hiding this comment.
Thanks for clarify and good job!
hiroppy
approved these changes
Jul 3, 2019
knagaitsev added a commit
to knagaitsev/webpack-dev-server
that referenced
this pull request
Jul 31, 2019
* fix(server): stricter headers security check * fix(server): changed comments explaining how server impl works
This was referenced Dec 14, 2019
This was referenced Feb 22, 2020
This was referenced Mar 13, 2020
This was referenced May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Headers security check for connecting clients should not allow a connection without headers: #2077
Breaking Changes
Changes the socket server implementation requirements such that headers must be passed to
onConnectioncallback.Additional Info