Uh oh!
There was an error while loading. Please reload this page.
test(server): increase port mapping base number - #2148
Conversation
Codecov Report
@@ Coverage Diff @@## master #2148 +/- ##
=======================================
Coverage 92.56% 92.56% =======================================
Files 33 33 Lines 1265 1265 Branches 361 361 =======================================
Hits 1171 1171 Misses 87 87 Partials 7 7Continue to review full report at Codecov.
|
| }; | ||
| let startPort = 8079; | ||
| let startPort = 8089; |
There was a problem hiding this comment.
Why did you change this? I thought it was only necessary to change the number of cli from 2 to 10.
There was a problem hiding this comment.
@hiroppy There are other tests that use the default ports near 8080, such as: https://github.com/webpack/webpack-dev-server/blob/master/test/server/utils/findPort.test.js. So I think we should provide some extra room to make sure those ports are available.
For Bugs and Features; did you add new tests?
N/A
Motivation / Use-Case
As mentioned in #2143, if we need to test CLI default port selection, which will use ports 8080, 8081, 8082... we should make sure the hard port mapping does not use these ports near port 8080. We just need to provide enough room for this default port assignment so that there will never be collisions.
Breaking Changes
None
Additional Info