Uh oh!
There was an error while loading. Please reload this page.
chore(deps): add webpack-cli to peers - #2188
Conversation
Codecov Report
@@ Coverage Diff @@## master #2188 +/- ##
=======================================
Coverage 96.08% 96.08% =======================================
Files 34 34 Lines 1227 1227 Branches 349 349 =======================================
Hits 1179 1179 Misses 47 47 Partials 1 1Continue to review full report at Codecov.
|
alexander-akait
commented
Aug 10, 2019
Thanks for PR, we can't do this, it is break CFA, vue-cli, angular-cli and etc, you should put webpack-cli in your deps, also next major release was without bin, and you need webpack-cli to run webpack-dev-server using CLI |
eps1lon
commented
Aug 10, 2019
@evilebottnawi Please read the PR description. I already have webpack-cli as a dependency but yarn v2 will throw errors if a package does not declare its dependencies. Maybe @arcanis could elaborate why this is important. |
arcanis
commented
Aug 10, 2019
I'll copy what I said on this issue:
|
alexander-akait
commented
Aug 12, 2019
Feel free to send a PR with |
For Bugs and Features; did you add new tests?
Can publish a package with this PR and see if it actually works but these kind of fixes have been done multiple times to make yarn v2 happy. Considering
webpack-dev-serverthrows at runtime anyway ifwebpack-cliis missing this shouldn't bother anyoneMotivation / Use-Case
yarn v2 throws currently with
Breaking Changes
I guess this new warning might be annoying if you don't run the
webpack-dev-servercli. If this is a blocker I can try and see if https://github.com/yarnpkg/rfcs/blob/master/accepted/0000-optional-peer-dependencies.md works for yarn v2.Additional Info