fix: add hostname and port to bonjour name to prevent name collisions

[roblan]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

It was impossible to run mutliple instances of webpack-dev-server if they all had bonjour because of 'name already in use' error.

Breaking Changes

No

Additional Info

[jsf-clabot]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #2276 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #2276 +/- ##
==========================================
+ Coverage 93.92% 93.92% +<.01% 
==========================================
Files 34 34 Lines 1283 1284 +1 Branches 369 366 -3 ==========================================
+ Hits 1205 1206 +1 - Misses 71 77 +6 + Partials 7 1 -6

Impacted Files	Coverage Δ
lib/utils/runBonjour.js	75% <100%> (+3.57%)	⬆️
client-src/clients/WebsocketClient.js	57.89% <0%> (ø)	⬆️
client-src/clients/SockJSClient.js	61.53% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1f24f...7e5e9f5. Read the comment docs.

[alexander-akait]

We still need test for this case

[roblan]

@evilebottnawi test added

[alexander-akait]

Just question - this names is used somewhere?

Sorry, i am not familiar with bonjour,

[roblan]

bonjour is used to broadcast services in current network, and it's used as service name

[alexander-akait]

maybe better use hostname from here

webpack-dev-server/lib/Server.js

Line 739 in 61b949e

returnthis.listeningApp.listen(port,hostname,(err)=>{

[roblan]

I've check it, and it's set to 'localhost' (by default I think and it will be in 9/10 cases) so it could still colide with some other webpack-dev-server in local network.

[alexander-akait]

@roblan port should be difference in this case, you can't run multiple webpack-dev-server using the same port

[roblan]

@evilebottnawi not on the same machine, but this name should be unique across local network.

[alexander-akait]

👍

[alexander-akait]

Need fix lint problem and we can merge

[roblan]

Should be ok now

[alexander-akait]

/cc @hiroppy@Loonride

[alexander-akait]

Thanks!