Uh oh!
There was an error while loading. Please reload this page.
Handle external upgrade for all websocket proxies - #843
Conversation
Codecov Report
@@ Coverage Diff @@## master #843 +/- ##
==========================================
+ Coverage 72.72% 73.05% +0.33%
==========================================
Files 4 4 Lines 407 412 +5 Branches 119 120 +1 ==========================================
+ Hits 296 301 +5
Misses 111 111
Continue to review full report at Codecov.
|
SpaceK33z
commented
Mar 14, 2017
Awesome!! Thanks, I'll release a new version today. |
SpaceK33z
commented
Mar 15, 2017
This is published in version |
shellscape
commented
Oct 18, 2017
@jamesblight in working on version 3, we've removed SockJS for sockets across the board, instead replacing it with |
This change upgrades websocket proxies so that an inital http request doesn't have to be made.
https://github.com/chimurai/http-proxy-middleware#external-websocket-upgrade
It supports a proposed change in Create React App by handling the upgrade of any websocket proxy passed in. react/create-react-app#1790
I added a test to confirm the upgrade