bindings.gyp forces `-arch arm64` on macos

[mayfield]

Hi,

I build a universal electron app but can't include bufferutil because it forces arm64 output..

bufferutil/binding.gyp

Lines 19 to 26 in 1b9081d

	'conditions': [
	# Use Perl v-strings to compare versions.
	['clang_version and <!(perl -e \'print <(clang_version) cmp 12.0.0\')==1', {
	'xcode_settings': {
	'OTHER_CFLAGS': ['-arch arm64'],
	'OTHER_LDFLAGS': ['-arch arm64']
	}
	}]

Can these lines be safely removed now? On my arm mac (v15), both cc and c++ -o/ld produce arm64 output without any arch hints.

Alternatively I could produce a PR that tests <(target_arch) and will set the appropriate -arch flags for cc and ld.

[mayfield]

I was building a couple PRs to choose from and when coming up with one that is minimally evasive I noticed that on my system -arch is already included. So it seems like the right thing to do is just remove the hard coded values unless there is some legacy system that required the -arch arguments being added manually, no?

:; npm install --build-from-source --verbose
npm verbose cli /opt/homebrew/Cellar/node/24.10.0/bin/node /opt/homebrew/bin/npm
npm info using npm@11.6.0
npm info using node@v24.10.0
npm warn Unknown cli config "--build-from-source". This will stop working in the next major version of npm.
npm verbose title npm install
npm verbose argv "install" "--build-from-source" "--loglevel" "verbose"
npm verbose logfile logs-max:10 dir:/Users/mayfield/.npm/_logs/2025-12-07T00_15_52_955Z-
npm verbose logfile /Users/mayfield/.npm/_logs/2025-12-07T00_15_52_955Z-debug-0.log
npm http fetch POST 200 https://registry.npmjs.org/-/npm/v1/security/advisories/bulk 186ms

> bufferutil@4.0.9 install
> node-gyp-build

clipped

gyp verb build type Release
gyp verb architecture arm64
gyp verb node dev dir /Users/mayfield/Library/Caches/node-gyp/24.10.0
gyp verb python /opt/homebrew/opt/python@3.14/bin/python3.14
gyp verb `which` succeeded for `make` /usr/bin/make
gyp verb bin symlinks created symlink to "/opt/homebrew/opt/python@3.14/bin/python3.14" in "/Users/mayfield/project/bufferutil/build/node_gyp_bins" and added to PATH
gyp info spawn make
gyp info spawn args [ 'V=1', 'BUILDTYPE=Release', '-C', 'build' ]
 cc -o Release/obj.target/bufferutil/src/bufferutil.o ../src/bufferutil.c '-DNODE_GYP_MODULE_NAME=bufferutil' '-DUSING_UV_SHARED=1' '-DUSING_V8_SHARED=1' '-DV8_DEPRECATION_WARNINGS=1' '-D_GLIBCXX_USE_CXX11_ABI=1' '-D_FILE_OFFSET_BITS=64' '-D_DARWIN_USE_64_BIT_INODE=1' '-D_LARGEFILE_SOURCE' '-DBUILDING_NODE_EXTENSION' -I/Users/mayfield/Library/Caches/node-gyp/24.10.0/include/node -I/Users/mayfield/Library/Caches/node-gyp/24.10.0/src -I/Users/mayfield/Library/Caches/node-gyp/24.10.0/deps/openssl/config -I/Users/mayfield/Library/Caches/node-gyp/24.10.0/deps/openssl/openssl/include -I/Users/mayfield/Library/Caches/node-gyp/24.10.0/deps/uv/include -I/Users/mayfield/Library/Caches/node-gyp/24.10.0/deps/zlib -I/Users/mayfield/Library/Caches/node-gyp/24.10.0/deps/v8/include -O3 -gdwarf-2 -fno-strict-aliasing -mmacosx-version-min=10.7 -arch arm64 -Wall -Wendif-labels -W -Wno-unused-parameter -arch arm64 -MMD -MF ./Release/.deps/Release/obj.target/bufferutil/src/bufferutil.o.d.raw -c
 c++ -bundle -arch arm64 -undefined dynamic_lookup -Wl,-search_paths_first -mmacosx-version-min=10.7 -arch arm64 -L./Release -stdlib=libc++ -o Release/bufferutil.node Release/obj.target/bufferutil/src/bufferutil.o 

Note the double inclusion of -arch for both cc and c++

[lpinca]

So it seems like the right thing to do is just remove the hard coded values unless there is some legacy system that required the -arch arguments being added manually, no?

When building on Intel, it is needed to build a universal binary that works on both Intel and Apple Silicon. When building on ARM it does not matter.