refactor(error): conver error types to enums - #37
Merged
Conversation
Move each error type to its own `error.rs` file within the respective module for better organization.
Replace the Cow-based ParsePatchError with a proper enum that has specific variants for each error case
Replace the Cow-based BinaryPatchParseError with a proper enum.
Convert PatchSetParseError from a Cow<'static, str> wrapper to a proper enum with specific variants for each error case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Including
ParsePatchErrorBinaryPatchParseErrorPatchSetParseError