Uh oh!
There was an error while loading. Please reload this page.
feat(tempo): add multisig config RPC method - #423
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:1c182df399
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export const multisig_getConfig = from({ | ||
| method: 'multisig_getConfig', | ||
| params: z.tuple([z.object({ address: z_Address.Address })]), | ||
| returns: z.nullable(z_MultisigConfig.Rpc), |
There was a problem hiding this comment.
When a client passes a successful RPC response to RpcSchema.decodeReturns, this schema only validates the wire object and leaves version as a hex string such as '0x0'. The RPC helpers promise wire-to-native decoding, and the existing MultisigConfig codec converts this response to MultisigConfig.Config with a bigint version (as already happens for configs nested in multisig operations). Using the raw Rpc schema here also prevents encodeReturns from accepting the corresponding native config; wrap z_MultisigConfig.MultisigConfig in z.nullable instead.
Useful? React with 👍 / 👎.
Adds
multisig_getConfigto the Tempo TypeScript and Zod RPC schemas, returningMultisigConfig.Rpcfor an account address ornullwhen no configuration exists.