Uh oh!
There was an error while loading. Please reload this page.
feat(tempo): serialize multisig key authorizations - #424
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:8f3c1a5bb0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| keyAuthorization: Hex.Hex, | ||
| options: serializeKeyAuthorization.Options, | ||
| ): Hex.Hex { | ||
| const authorization = KeyAuthorization_.deserialize(keyAuthorization) |
There was a problem hiding this comment.
When the unsigned authorization omits account or binds it to an address other than options.account, this function still produces a multisig-signed authorization. That output cannot represent a valid multisig key-authorization operation: assertKeyAuthorization later rejects it with key authorization account does not match the operation account. Validate the authorization's account binding here so a normal getHash → selectApprovals → serialization flow cannot return an artifact that this module itself considers invalid.
Useful? React with 👍 / 👎.
Adds
MultisigOperation.serializeKeyAuthorizationto attach a selected multisig quorum to canonical unsigned key authorizations. This gives offchain coordinators an Ox-owned finalization path.