Skip to content

Upgrade path to Pydantic 2.0 - #35

Merged
turukawa merged 8 commits into
masterfrom
upgrade-path-to-pydantic-2.0
Aug 11, 2023
Merged

Upgrade path to Pydantic 2.0#35
turukawa merged 8 commits into
masterfrom
upgrade-path-to-pydantic-2.0

Conversation

@turukawa

@turukawaturukawa commented Jul 25, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Major path updates include:

  • frontend:
    • Node 16 to 18
    • Latest Pinia requires changes in stores, where imports are not required (cause actual errors), and parameter declaration must happen in functions.
  • backend and celeryworker:
    • Python 3.9 to 3.11
    • FastAPI 0.88 to 0.99 (Inboard 0.37 to 0.51)
    • Poetry to Hatch
    • Postgres 14 to 15

Review required on the new hatchpyproject.toml file, and to ensure that the environments are stable. @br3ndonland, I'd appreciate your review.

@turukawa
Upgrade path to Pydantic 2.0
002bfa5
Major path updates include:
- frontend:
- Node 16 to 18
- Latest Pinia requires changes in `stores`, where imports are not required, and parameter declaration must happen in functions.
- backend and celeryworker:
- Python 3.9 to 3.11
- Poetry to Hatch
- Postgres 14 to 15
@turukawaturukawa mentioned this pull request Jul 25, 2023
Closed
@turukawa

turukawa commented Jul 25, 2023

Copy link
Copy Markdown
MemberAuthor

Getting this error on backend when calling the api:

2023-07-25 10:26:06 Traceback (most recent call last):
2023-07-25 10:26:06 File "<frozen runpy>", line 198, in _run_module_as_main
2023-07-25 10:26:06 File "<frozen runpy>", line 88, in _run_code
2023-07-25 10:26:06 File "/app/inboard/start.py", line 135, in <module>
2023-07-25 10:26:06 start_server(
2023-07-25 10:26:06 File "/app/inboard/start.py", line 123, in start_server
2023-07-25 10:26:06 uvicorn.run(**uvicorn_options) # type: ignore[arg-type]
2023-07-25 10:26:06 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2023-07-25 10:26:06 File "/app/.venv/lib/python3.11/site-packages/uvicorn/main.py", line 573, in run
2023-07-25 10:26:06 ChangeReload(config, target=server.run, sockets=[sock]).run()
2023-07-25 10:26:06 File "/app/.venv/lib/python3.11/site-packages/uvicorn/supervisors/basereload.py", line 50, in run
2023-07-25 10:26:06 for changes in self:
2023-07-25 10:26:06 File "/app/.venv/lib/python3.11/site-packages/uvicorn/supervisors/basereload.py", line 69, in __next__
2023-07-25 10:26:06 return self.should_restart()
2023-07-25 10:26:06 ^^^^^^^^^^^^^^^^^^^^^
2023-07-25 10:26:06 File "/app/.venv/lib/python3.11/site-packages/uvicorn/supervisors/statreload.py", line 32, in should_restart
2023-07-25 10:26:06 for file in self.iter_py_files():
2023-07-25 10:26:06 File "/app/.venv/lib/python3.11/site-packages/uvicorn/supervisors/statreload.py", line 52, in iter_py_files
2023-07-25 10:26:06 for path in list(reload_dir.rglob("*.py")):
2023-07-25 10:26:06 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2023-07-25 10:26:06 File "/usr/local/lib/python3.11/pathlib.py", line 968, in rglob
2023-07-25 10:26:06 for p in selector.select_from(self):
2023-07-25 10:26:06 File "/usr/local/lib/python3.11/pathlib.py", line 408, in _select_from
2023-07-25 10:26:06 for p in successor_select(starting_point, is_dir, exists, scandir):
2023-07-25 10:26:06 File "/usr/local/lib/python3.11/pathlib.py", line 356, in _select_from
2023-07-25 10:26:06 entries = list(scandir_it)
2023-07-25 10:26:06 ^^^^^^^^^^^^^^^^
2023-07-25 10:26:06 OSError: [Errno 12] Cannot allocate memory: '/app/app'

@turukawa
Reference fixes
55e3ef4
Celeryworker fix:
Recommended `hatch run production:python /app/app/celeryworker_pre_start.py` does not work. Use `hatch run python /app/app/celeryworker_pre_start.py` instead.
Frontend:
Weird issue with latest version of Vite: #35
Requires changing of `/app` to *any other directory name*. This is a Docker/Vite issue and may be fixed in a future version of Vite.
@turukawa

turukawa commented Jul 25, 2023

Copy link
Copy Markdown
MemberAuthor

The fix to frontend is related to a Vite error: scj2000/scj2000-web-v2@b923143

@turukawa
Fixing Pinia referencing changes
85307cd
 Fixing Pinia referencing changes and standardising naming conventions
@turukawa
Changed token invalidation to removal
9ae8786
- Token invalid settings seems somewhat pointless ... just remove it entirely to avoid risk of weird conflicts
- Simplified crud paging with a site-level setting ... risk of some sort of DoS attack by having a way to bypass row-fetch limits
- Placeholder for a sockets-based API
br3ndonland
br3ndonland suggested changes Jul 29, 2023
View reviewed changes

@br3ndonlandbr3ndonland left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turukawa. Great to see Hatch and inboard put to good use here. I have a few suggestions. Feel free to let me know if any further clarifications or changes are needed.

Comment thread{{cookiecutter.project_slug}}/backend/app/__version__.py
Comment thread{{cookiecutter.project_slug}}/backend/app/pyproject.toml Outdated
Comment thread{{cookiecutter.project_slug}}/backend/app/pyproject.toml Outdated
Comment thread{{cookiecutter.project_slug}}/backend/backend.dockerfile Outdated
Comment thread{{cookiecutter.project_slug}}/backend/app/pyproject.toml
Comment thread{{cookiecutter.project_slug}}/backend/app/pyproject.toml Outdated
Comment thread{{cookiecutter.project_slug}}/backend/app/pyproject.toml Outdated
Comment thread{{cookiecutter.project_slug}}/backend/backend.dockerfile Outdated
Comment thread{{cookiecutter.project_slug}}/backend/backend.dockerfile Outdated
Comment thread{{cookiecutter.project_slug}}/backend/celeryworker.dockerfile
@turukawa
turukawa merged commit c5cd1ba into masterAug 11, 2023
@turukawa
turukawa deleted the upgrade-path-to-pydantic-2.0 branch August 11, 2023 09:16
ai-28 pushed a commit to ai-28/fastAPI-mongoDB that referenced this pull request Mar 27, 2025
echocraft201315
Reference fixes
35489f4
Celeryworker fix:
Recommended `hatch run production:python /app/app/celeryworker_pre_start.py` does not work. Use `hatch run python /app/app/celeryworker_pre_start.py` instead.
Frontend:
Weird issue with latest version of Vite: whythawk/full-stack-fastapi-postgresql#35
Requires changing of `/app` to *any other directory name*. This is a Docker/Vite issue and may be fixed in a future version of Vite.
siriusblack-7c added a commit to siriusblack-7c/Full-Stack-FastAPI-React-MongoDB-FARM-Base-Project-Generator that referenced this pull request May 30, 2025
@siriusblack-7c
Reference fixes
6bdbd74
Celeryworker fix:
Recommended `hatch run production:python /app/app/celeryworker_pre_start.py` does not work. Use `hatch run python /app/app/celeryworker_pre_start.py` instead.
Frontend:
Weird issue with latest version of Vite: whythawk/full-stack-fastapi-postgresql#35
Requires changing of `/app` to *any other directory name*. This is a Docker/Vite issue and may be fixed in a future version of Vite.
DragonWhite500 added a commit to DragonWhite500/full-stack-fastapi-mongodb that referenced this pull request Jul 14, 2025
@DragonWhite500
Reference fixes
d0a4d47
Celeryworker fix:
Recommended `hatch run production:python /app/app/celeryworker_pre_start.py` does not work. Use `hatch run python /app/app/celeryworker_pre_start.py` instead.
Frontend:
Weird issue with latest version of Vite: whythawk/full-stack-fastapi-postgresql#35
Requires changing of `/app` to *any other directory name*. This is a Docker/Vite issue and may be fixed in a future version of Vite.
tb91117 added a commit to tb91117/fastapi-mongodb-full-stack that referenced this pull request Jul 31, 2025
@tb91117
Reference fixes
0977be9
Celeryworker fix:
Recommended `hatch run production:python /app/app/celeryworker_pre_start.py` does not work. Use `hatch run python /app/app/celeryworker_pre_start.py` instead.
Frontend:
Weird issue with latest version of Vite: whythawk/full-stack-fastapi-postgresql#35
Requires changing of `/app` to *any other directory name*. This is a Docker/Vite issue and may be fixed in a future version of Vite.
xcho7i added a commit to xcho7i/Full-Stack-FastAPI-React-MongoDB-FARM-Base-Project-Generator that referenced this pull request Aug 4, 2025
@xcho7i
Reference fixes
35e4834
Celeryworker fix:
Recommended `hatch run production:python /app/app/celeryworker_pre_start.py` does not work. Use `hatch run python /app/app/celeryworker_pre_start.py` instead.
Frontend:
Weird issue with latest version of Vite: whythawk/full-stack-fastapi-postgresql#35
Requires changing of `/app` to *any other directory name*. This is a Docker/Vite issue and may be fixed in a future version of Vite.
bee-dev215 added a commit to bee-dev215/full-stack-fastapi-mongodb that referenced this pull request Aug 17, 2025
@bee-dev215
Reference fixes
cb7c529
Celeryworker fix:
Recommended `hatch run production:python /app/app/celeryworker_pre_start.py` does not work. Use `hatch run python /app/app/celeryworker_pre_start.py` instead.
Frontend:
Weird issue with latest version of Vite: whythawk/full-stack-fastapi-postgresql#35
Requires changing of `/app` to *any other directory name*. This is a Docker/Vite issue and may be fixed in a future version of Vite.
SIntel423 added a commit to SIntel423/fullstack-fastapi-mongodb that referenced this pull request Sep 19, 2025
@SIntel423
Reference fixes
09346da
Celeryworker fix:
Recommended `hatch run production:python /app/app/celeryworker_pre_start.py` does not work. Use `hatch run python /app/app/celeryworker_pre_start.py` instead.
Frontend:
Weird issue with latest version of Vite: whythawk/full-stack-fastapi-postgresql#35
Requires changing of `/app` to *any other directory name*. This is a Docker/Vite issue and may be fixed in a future version of Vite.
candaleadrian pushed a commit to candaleadrian/full-stack-fastapi-mongodb-frontend that referenced this pull request Sep 22, 2025
@turukawa
Reference fixes
21e9fcc
Celeryworker fix:
Recommended `hatch run production:python /app/app/celeryworker_pre_start.py` does not work. Use `hatch run python /app/app/celeryworker_pre_start.py` instead.
Frontend:
Weird issue with latest version of Vite: whythawk/full-stack-fastapi-postgresql#35
Requires changing of `/app` to *any other directory name*. This is a Docker/Vite issue and may be fixed in a future version of Vite.
candaleadrian pushed a commit to candaleadrian/full-stack-fastapi-mongodb-backend that referenced this pull request Sep 22, 2025
@turukawa
Reference fixes
54f7c7c
Celeryworker fix:
Recommended `hatch run production:python /app/app/celeryworker_pre_start.py` does not work. Use `hatch run python /app/app/celeryworker_pre_start.py` instead.
Frontend:
Weird issue with latest version of Vite: whythawk/full-stack-fastapi-postgresql#35
Requires changing of `/app` to *any other directory name*. This is a Docker/Vite issue and may be fixed in a future version of Vite.
ai-28 added a commit to ai-28/fastAPI-mongoDB that referenced this pull request Oct 21, 2025
@ai-28
Reference fixes
d77c7fc
Celeryworker fix:
Recommended `hatch run production:python /app/app/celeryworker_pre_start.py` does not work. Use `hatch run python /app/app/celeryworker_pre_start.py` instead.
Frontend:
Weird issue with latest version of Vite: whythawk/full-stack-fastapi-postgresql#35
Requires changing of `/app` to *any other directory name*. This is a Docker/Vite issue and may be fixed in a future version of Vite.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@br3ndonlandbr3ndonlandbr3ndonland requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@turukawa@br3ndonland