custom extensions

[farvardin]

Use Case

Hello, I've just discovered gitnote. Cool app!

At the moment gitnote only allows to sync (retrieve and upload) *.md and *.txt files. There are other lightweight text formats such as restructured text, txt2tags, creole, asciidoc etc.

https://en.wikipedia.org/wiki/Category:Lightweight_markup_languages

Proposed Change

Allow custom extensions, so instead of just *.md and *.txt we could use whatever we want (even *.c *.html)

[wiiznokes]

Hey, thanks!

This is a know issue, and there is unfortunatelly no easy solution.
Currently, there is two place in the app where we filter files based on extension:

• in kotlin when we add file to the database:

  gitnote/app/src/main/java/io/github/wiiznokes/gitnote/data/room/Dao.kt

  Line 55 in 203dbfa

  val mimeType = MimeTypeMap.getSingleton()

• in rust when we get the files timestamps:

  gitnote/app/src/main/rust/src/mime_types.rs

  Line 5 in 203dbfa

  pub fn is_extension_supported(extension: &str) -> bool {

(Technically, we could use ffi to reuse one implementation)
Unfortunatelly, both implemenation maitain a list of mime type for file extension, so a lot of utf-8 file will be omitted.
I already added some custom extension here:

gitnote/app/src/main/rust/src/mime_types.rs

Line 3 in 203dbfa

const ADDITIONAL_SUPPORTED_EXTENSIONS: &[&str] = &["sh", "fish", "ps1", "bat"];

I guess we could add a setting for this but i don't think i will work on this (i could merge a pr if someone implement it).

A simpler solution for now could be to just hardcode custom file extension in the app code.

[wiiznokes]

let me know if there are other file extension you're interested in :)

[farvardin]

even though I don't use it myself, I suppose some people might want to use the .org extension for org-mode https://en.wikipedia.org/wiki/Org-mode

I was not saying to add all existing extension, just to have a field for entering a custom extension instead of having to choose between *.txt and *.md but maybe it's complicated

[wiiznokes]

Oh you mean being able to create notes with custom extension. This will be useful but for creating file like .c or .html, I don't think the current solution (a settings to set a default extension for new notes) is a good fit, since this would probably just be for one specific file.

So yeah we could add that, even tho this will be tricky, since we need to remember to include the custom extension in the database, and this involve two programming language

[pikodd]

It would be cool if you add AsciiDoc(.adoc, .asciidoc) support. It is more reliable, than markdown

[wiiznokes]

It would be cool if you add AsciiDoc(.adoc, .asciidoc) support. It is more reliable, than markdown

Added in a21fbc6. Tho, there is no preview for it currently, but you can now edit those files