Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jun 15, 2026. It is now read-only.
Fix nested function literal. - #47
Merged
Merged
Conversation
Hi Greg Lincoln (@tetious), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
John-David Dalton (jdalton)
commented
Jul 7, 2015
Contributor
Nice catch Greg Lincoln (@tetious)! For reference a summary of the issue with function declarations in blocks can be found at https://jslinterrors.com/function-statements-should-not-be-placed-in-blocks |
John-David Dalton (jdalton) added a commit
that referenced
this pull request
Jul 7, 2015
Fix nested function literal.
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This violates strict-mode, and breaks Safari on MacOS/iOS.