Skip to content

Fixed some problems - #29

Open
Antonio171003 wants to merge 13 commits into
wiringbits:mainfrom
Antonio171003:main
Open

Fixed some problems#29
Antonio171003 wants to merge 13 commits into
wiringbits:mainfrom
Antonio171003:main

Conversation

@Antonio171003

@Antonio171003Antonio171003 commented Jun 6, 2024

Copy link
Copy Markdown
Contributor
  • Update React-Admin version to '4.14.4'.
  • Fixed the filter functionality when the parameter is a reference.
  • Fixed an Internal Server Error, Caused when attempting to filter by a column whose data type is not a string.
  • Fixed : Failed prop type: Invalid prop on Reference Field.
  • Fixed bugs related to image handling (saving and reading) and added a data provider to manage them.

@Antonio171003Antonio171003 changed the title Added all tables from data base and fixed some problemsFixed some problemsJun 6, 2024

@KapStormKapStorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create many PR request as many features/bug fixes/etc, if we want to solve 4 issues then we should create 4 separated PR

There are many function that have undesirable empty spaces like:

defTest():Boolean= {
// <- this type of spaces1==1// <- this type of spaces
}

Please remove them

There are many spaces that are missing between functions, like:

defTemp1():Unit= {
...
} // <- add space heredefTemp2():Unit= {
...
}

Comment threadspra-play-server/src/main/resources/application.conf Outdated
Comment threadspra-web/src/main/scala/net/wiringbits/spra/ui/web/facades/package.scala Outdated

@KapStormKapStorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Antonio171003@KapStorm