Data-only notifications should not show empty notifications - #780
Data-only notifications should not show empty notifications#780callaars wants to merge 2 commits into
Conversation
Accidental extra line break.
|
cc @VitalyArt / @yogevbd |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
You are stale. |
|
At current last version I don't see push text. Only application title & empty body, |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
The issue has been closed for inactivity. |
|
This PR is not stale. I'm experiencing the same issue. Please can a contributor help get this work merged. |
|
It's definitely still happening. |
|
@DanielEliraz Can I bring your attention to this fix too please? |
|
OK, accepting! thanks @callaars! |
|
@callaars replaced it with a new PR, thanks man |
As described in this issue #684 notifications are displayed as empty notifications in Android when no title and body is set.
This PR mitigates that by not creating a notification if both are not available.
I couldn't find a CONTRIBUTING file so I'm just pushing this as a PR. Let me know if something is off or needs fixing. I've tested this, obviously, and it works as intended.