Uh oh!
There was an error while loading. Please reload this page.
Clarify contracts of toArray methods - #322
Conversation
JeroenDeDauw
commented
Nov 28, 2014
\o/ Can you leave +2 to the rest |
thiemowmde
commented
Nov 29, 2014
It's just a comment. Remove it if you think it's a problem. I don't have a problem with that. |
JeroenDeDauw
commented
Dec 1, 2014
Comment or not, it causes a merge conflict. I'll amend your commit when I look at this again, if you have not done so already |
thiemowmde
commented
Dec 1, 2014
So we are not allowed to improve certain code any more because we have a branch now? Doesn't make much sense. |
thiemowmde
commented
Jan 14, 2015
Wow. A super-trivial documentation change blocked for 2 months now. Pinging @tobijat since we apparently still need a nurse. |
JeroenDeDauw
commented
Jan 14, 2015
Note how this is not blocked at all (no -2 has been given). I asked you if you could do me a favour, and you got mad about it. Then nobody looked at this. |
Clarify contracts of toArray methods
As requested in #311 (comment).
Please note that
StatementListalways reindexed the array. It stopped doing this with #285 (released with 2.4.0).I think this must be the responsibility of the
StatementListclass (as well asClaimList, see the TODO) and not the calling code.