Uh oh!
There was an error while loading. Please reload this page.
New methods to add and remove aliases from an AliasGroupList - #474
New methods to add and remove aliases from an AliasGroupList#474Benestar wants to merge 1 commit into
Conversation
thiemowmde
commented
May 6, 2015
-2 for the moment. Where is this needed and why? |
Benestar
commented
May 6, 2015
Please read my commit and PR message:
I mean really, it is written there quite clearly, isn't it? |
thiemowmde
commented
May 6, 2015
There is literally not a single use of |
Benestar
commented
May 6, 2015
There might be other users of this library who need that functionality for adding and removing aliases. However, you are right that this is not needed for Wikibase itself so I will leave this PR open but make the other patches in the chain not depend on this one. This patch then has low priority. Thanks for the notice, @thiemowmde :-) |
JeroenDeDauw
commented
May 6, 2015
I agree that we should have usecases for such methods outside of the tests for deprecated code. |
Benestar
commented
May 6, 2015
Closing this for now. We can still add those methods when there is a need for them. |
These methods should act as a replacement for
Entity::addAliasesandEntity::removeAliasesas those methods are deprecated and there exists no simple replacement yet.