Uh oh!
There was an error while loading. Please reload this page.
Do not return anything from Entity setters - #496
Merged
Conversation
JeroenDeDauw
commented
Jun 3, 2015
Contributor
Rel notes do need updating. This bevahour has been there since 0.1 and was replied on back then. |
Benestar
commented
Jun 3, 2015
Contributor
Have to read comments in full... So +2 from my side if release notes are updated |
thiemowmdeforce-pushed
the
settersAreSetters
branch
from
June 4, 2015 08:27
db1d4b8 to
1e3d483Comparethiemowmde
commented
Jun 4, 2015
ContributorAuthor
Release notes updated. |
addshore added a commit
that referenced
this pull request
Jun 5, 2015
Do not return anything from Entity setters
ContributorAuthor
There was a problem hiding this comment.
How is a method added to an interface a breaking change? I can't think of a way how does this could break existing code.
Contributor
There was a problem hiding this comment.
Imagine you implement the interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized this in #492 (comment).
I consider this a mistake that's not worth any documentation.I did a quick check in our code base and could not find a user relying on these return values.The renamed method is unrelated, I just found this setter that's not a setter while searching for setters that may return something.