fix(pipe): bind loaded notices to process identity - #1
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f1292dc9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (GetProcessTimes(GetCurrentProcess(), &CreationTime, &ExitTime, &KernelTime, &UserTime)) { | ||
| CreationIdentity.LowPart = CreationTime.dwLowDateTime; | ||
| CreationIdentity.HighPart = CreationTime.dwHighDateTime; | ||
| pipe("LOADED:%d,i:%llu", GetCurrentProcessId(), (unsigned long long)CreationIdentity.QuadPart); |
There was a problem hiding this comment.
pipe() is not printf: _pipe_sprintf() only supports %z, %c, %Z, %F, %s, %S, %o, %O, %d, %x, and %p. Consequently %llu is emitted as -- UNKNOWN FORMAT STRING -- lu rather than consuming and serializing CreationIdentity.QuadPart, so every successful GetProcessTimes() call sends a malformed LOADED notice and the analyzer cannot validate the process identity.
Useful? React with 👍 / 👎.
|
Superseded by upstream PR kevoreilly#197. The branch and successful MSBuild run 34073283202 are retained for review provenance. |
Build-validation PR for the WMI provider monitoring fix. Extends LOADED with a tagged process creation FILETIME so CAPEv2 can reject stale PID-reuse notifications while remaining compatible with older monitors.