Skip to content

Boost.Asio 1.65.1 with wolfSSL support - #18

Merged
ejohnstown merged 2 commits into
wolfSSL:masterfrom
dgarske:asio_1.65.1
Jul 29, 2021
Merged

Boost.Asio 1.65.1 with wolfSSL support#18
ejohnstown merged 2 commits into
wolfSSL:masterfrom
dgarske:asio_1.65.1

Conversation

@dgarske

@dgarskedgarske commented Aug 2, 2018

Copy link
Copy Markdown
Member

This PR requires
wolfSSL/wolfssl#1739

@dgarskedgarske assigned dgarske and toddouska and unassigned dgarskeAug 2, 2018
@dgarske
dgarske requested a review from MJSPollardAugust 7, 2018 16:00
@dgarskedgarske assigned dgarske and unassigned toddouskaAug 8, 2018
@dgarske

Copy link
Copy Markdown
MemberAuthor

Closing as its redudant with PR #20 from @MJSPollard. Only difference is the define used in this PR was WOLFSSL_ASIO and new PR 20 is ASIO_USE_WOLFSSL.

@dgarskedgarske closed this Aug 8, 2018
@dgarske

Copy link
Copy Markdown
MemberAuthor

It looks like there are other differences, so keeping this PR open since this specific version is required for SSF.

@dgarskedgarske reopened this Aug 8, 2018

@MJSPollardMJSPollard left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tests out well and can be merged in. The only comment I have is that the asio_1_65_1/asio directory is not actually needed and can be deleted.

@dgarskedgarske assigned toddouska and unassigned dgarskeAug 10, 2018
@dgarskedgarske assigned ejohnstown and unassigned toddouskaJul 28, 2021
@ejohnstown
ejohnstown self-requested a review July 28, 2021 23:27

@ejohnstownejohnstown left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to build this with wolfSSL. It passed make check. I confirmed that libwolfssl was linked in.

@ejohnstown
ejohnstown merged commit 838c851 into wolfSSL:masterJul 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@dgarske@ejohnstown@MJSPollard@toddouska