Skip to content

Add Agilex 5 FCS and wolfBoot integration - #846

Open
aidangarske wants to merge 5 commits into
wolfSSL:masterfrom
aidangarske:agilex5-tfa-port
Open

Add Agilex 5 FCS and wolfBoot integration#846
aidangarske wants to merge 5 commits into
wolfSSL:masterfrom
aidangarske:agilex5-tfa-port

Conversation

@aidangarske

@aidangarskeaidangarske commented Aug 6, 2026

Copy link
Copy Markdown
Member

Description

  • Adds the Altera Agilex 5 013B wolfBoot port for the GSRD SD-card boot flow
  • Preserves the existing SPL and TF-A responsibilities for DDR, clocks, resets, PSCI, and EL3
  • Loads wolfBoot as the signed BL33 payload at 0x80200000
  • Adds Agilex 5 SDHCI and platform initialization support
  • Integrates signed Linux FIT images with wolfBoot verification
  • Adds a four-partition WIC layout with initialized A and B image slots
  • Adds Yocto/meta-wolfSSL integration, CI coverage, and customer bring-up documentation
  • Validated the generated WIC through the customer Kas build and on Agilex 5 hardware

partner pr: wolfSSL/meta-wolfssl#177

CopilotAI lite review requested due to automatic review settings August 6, 2026 23:19

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Adds an Altera Agilex 5 (013B) port and integration points to boot wolfBoot as BL33 in the GSRD SD-card flow, including SDHCI/platform init, memory mapping, example FIT artifacts, and CI build coverage.

Changes:

  • Adds Agilex 5 HAL (C + header), linker script, FIT example, and a BL33 smoke-test app.
  • Updates AArch64 startup/MMU mappings and SDHCI behavior to support Agilex 5 boot/SD timing.
  • Updates disk-boot logging and adds docs/config + GitHub Actions build coverage for the new target.

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Show a summary per file
FileDescription
test-app/app_agilex5.cAdds a BL33 smoke-test app for Agilex 5 (timer + EL print).
src/update_disk.cImproves disk-boot debug output (block size + pointer-format prints).
src/sdhci.cAdds command-line reset, inhibit timeouts, optional post-command delay, and CMD8 retry logic.
src/boot_aarch64_start.SAdds Agilex 5 include, adjusts CNTFRQ/RVBAR handling, and adds Agilex 5 MMU mappings.
src/boot_aarch64.cAdds Agilex 5 HAL include selection for AArch64 boot code.
include/sdhci.hAdds reset bit definitions and new SDHCI tuning/behavior macros.
hal/agilex5.ldNew linker script matching BL33 placement at 0x80200000.
hal/agilex5.itsExample FIT description for Agilex 5 Linux payload (kernel + DTB).
hal/agilex5.hNew Agilex 5 target configuration and platform constants.
hal/agilex5.cNew Agilex 5 HAL implementation (timer, UART, DT fixups, SDHCI PHY + DMA cache ops).
docs/Targets.mdDocuments the new Agilex 5 target and references Agilex5 bring-up doc.
docs/Agilex5.mdAdds bring-up and integration documentation (GSRD/FIT/WIC/test order/CI).
config/examples/agilex5_013b_sdcard.configAdds a buildable example config for Agilex 5 SD-card boot flow.
arch.mkAdds Agilex 5 AArch64 flags + target-specific bootloader responsibilities.
.github/workflows/test-configs.ymlAdds Agilex 5 config to existing CI matrix via reusable workflow.
.github/workflows/test-build-agilex5.ymlAdds a dedicated Agilex 5 build workflow (path-filtered).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadtest-app/app_agilex5.c Outdated
Comment threadtest-app/app_agilex5.c Outdated
Comment threadsrc/update_disk.c
Comment threadsrc/sdhci.c
Comment threadhal/agilex5.c
Comment threaddocs/Agilex5.md Outdated
Comment threadsrc/boot_aarch64_start.S Outdated

@wolfSSL-Fenrir-botwolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #846

Scan targets checked:wolfboot-bugs, wolfboot-src

Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment threadhal/agilex5.h Outdated
Comment threadsrc/update_disk.c Outdated
Comment threadinclude/sdhci.h
Comment threadhal/agilex5.c Outdated
@aidangarske
aidangarske marked this pull request as ready for review August 7, 2026 21:23
@dgarskedgarske removed their assignment Aug 10, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@aidangarske@wolfSSL-Fenrir-bot@danielinux@dgarske@wolfSSL-Bot@night1rider