Skip to content

Validate DH peer public key subgroup before key agreement - #460

Open
aidangarske wants to merge 4 commits into
wolfSSL:masterfrom
aidangarske:worktree-dh-subgroup-check
Open

Validate DH peer public key subgroup before key agreement#460
aidangarske wants to merge 4 commits into
wolfSSL:masterfrom
aidangarske:worktree-dh-subgroup-check

Conversation

@aidangarske

Copy link
Copy Markdown
Member
F-5914

@aidangarske
aidangarske requested review from ColtonWilley and padelsbach and a lite review from CopilotAugust 6, 2026 20:00
@aidangarskeaidangarske self-assigned this Aug 6, 2026

@wolfSSL-Fenrir-botwolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #460

Scan targets checked:wolfprovider-bugs, wolfprovider-src

Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

CopilotAI reviewed Aug 6, 2026

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@wolfSSL-Fenrir-botwolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #460

Scan targets checked:wolfprovider-bugs, wolfprovider-src

Findings: 3
3 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

Comment threadsrc/wp_dh_exch.c
Comment threadtest/test_dh.c Outdated
Comment threadtest/test_dh.c Outdated
@aidangarskeaidangarske added the ci:all PR OSP toggle: run all label Aug 7, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:allPR OSP toggle: run all

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@aidangarske@wolfSSL-Fenrir-bot