Deduplication and type checking

[stenslae]

• Added authorized_key type checking extract the embedded key type directly from the SSH wire-format blob rather than using wolfSSH_QueryKey().
• Added a makeKey function pointer to CompositeTradOps.
• Deduplicated ECDSA Encoding
• Introduced WOLFSSH_MLDSA_COMPOSITE_ID_CASES for redundant switch cases.
• Centralized maximum public key sizing behind a new WOLFSSH_MLDSA_MAX_PUB_KEY_SZ macro
• Switched to dynamically allocating MlDsaKey and large public key buffers in wolfSSH_MakeMlDsaCompositeKey() and GetOpenSshKeyMlDsaComposite() when WOLFSSH_SMALL_STACK is defined.
• Added test coverage

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #1159

Scan targets checked:wolfssh-bugs, wolfssh-src

Findings: 5
5 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #1159

Scan targets checked:wolfssh-bugs, wolfssh-src

Findings: 7
7 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #1159

Scan targets checked:wolfssh-bugs, wolfssh-src

Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

[wolfSSL-Fenrir-bot]

Fenrir Automated Review — PR #1159

Scan targets checked:wolfssh-bugs, wolfssh-src

Findings: 4
4 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Findings are non-blocking.

[wolfSSL-Fenrir-bot]

🔵 [Low] Truncated-blob test never reaches the bound it claims to cover · Weak or missing assertions

The line token rsa-sha2-256 is mapped by AuthKeysTokenKeyType() to ssh-rsa, so keyTypeSz is 7 while the blob declares 12; typeStrSz != keyTypeSz rejects first and the typeStrSz > keyCandSz - 4 bound in CheckAuthKeysLine() stays untested. Deleting that bound leaves the suite green.

Fix: Use a non-aliased token whose length equals the declared type length, e.g. token "ssh-rsa" with blob { 0,0,0,7, 's','s','h' }.

[wolfSSL-Fenrir-bot]

🔵 [Low] WOLFSSH_NO_MLDSA_COMPOSITES not applied to cannedKeyAlgoClient · Logic errors

The new WOLFSSH_NO_MLDSA_COMPOSITES option guards cannedKeyAlgoNames and cannedKeyAlgoNamesHostKey but not cannedKeyAlgoClient, so composite IDs still match in DoUserAuthRequestPublicKey() and DoExtInfoServerSigAlgs() while WS_GetCompositeParams() now always returns WS_NOT_COMPILED.

Fix: Wrap the six composite ID entries in cannedKeyAlgoClient with #ifndef WOLFSSH_NO_MLDSA_COMPOSITES.

[wolfSSL-Fenrir-bot]

🔵 [Low] Truncated-blob test never reaches the new out-of-bounds guard in CheckAuthKeysLine · Missing edge-case coverage on a function the PR also changed

The vector declares a 12-byte type length while the normalized line type ssh-rsa is 7, so typeStrSz != keyTypeSz short-circuits first and the typeStrSz > keyCandSz - 4 guard at auth.c:332 is never exercised. That guard is the only thing preventing XMEMCMP from reading past the decoded keyCand heap allocation.

Fix: Use a vector where the declared type length equals the line type length but exceeds keyCandSz - 4, e.g. line type ssh-ed25519 with blob {0,0,0,11,'x','x','x','x'}.

[wolfSSL-Fenrir-bot]

🔵 [Low] Fail-soft malformed-line handling applied only to the Base64 branch · Privilege escalation in wolfsshd

Base64 decode failure now yields WSSHD_AUTH_FAILURE so the scan continues, but the sibling tokenization failure at lines 293–298 still returns WS_FATAL_ERROR, which makes SearchKeysFile abort the whole file. A single whitespace-free non-comment line in authorized_keys therefore denies auth for every key listed after it; the new SearchForPubKey malformed-line test uses a two-token line and does not cover this.

Fix: Return WSSHD_AUTH_FAILURE for tokenization failures as well, and add a single-token-line case to test_SearchForPubKey.