Uh oh!
There was an error while loading. Please reload this page.
RFC-4256 Keyboard-Interactive authentication - #763
Merged
Conversation
LinuxJediforce-pushed
the
RFC-4256
branch
5 times, most recently
from
January 31, 2025 20:36
bab5784 to
9e7bd3fCompareLinuxJedi
marked this pull request as draft
January 31, 2025 20:49
LinuxJediforce-pushed
the
RFC-4256
branch
3 times, most recently
from
February 3, 2025 08:37
d385689 to
8d1a669CompareLinuxJedi
marked this pull request as ready for review
February 3, 2025 08:55
LinuxJediforce-pushed
the
RFC-4256
branch
5 times, most recently
from
February 4, 2025 15:32
5f68a6c to
4f65c0bCompareLinuxJedi
commented
Feb 4, 2025
MemberAuthor
Added additional packet checks and an additional test. |
LinuxJediforce-pushed
the
RFC-4256
branch
2 times, most recently
from
February 4, 2025 17:05
8ee69de to
de0f986CompareLinuxJediforce-pushed
the
RFC-4256
branch
2 times, most recently
from
February 5, 2025 13:18
fbef091 to
7ea9f8fCompareejohnstown
requested changes
Feb 6, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ejohnstown
previously approved these changes
Feb 10, 2025
JacobBarthelmeh
requested changes
Feb 11, 2025
JacobBarthelmeh
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Few minor nit items, but functionally it looks good.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
So, this is currently failing a couple of matrix tests because the apt mirror GH actions uses for ubuntu-latest is broken. I'll try to remember to re-run in a few hours. |
This implements Keyboard-Interactive authentication. Adds an additional callback set by `wolfSSH_KeyboarAuthPrompts()` which will set a callback in the server to ask the application to provide the prompt details for the client.
LinuxJedi
commented
Feb 11, 2025
MemberAuthor
Additional force-push to fix GitHub workflows apt-get problem. |
JacobBarthelmeh
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements Keyboard-Interactive authentication.
Adds an additional callback set by
wolfSSH_KeyboarAuthPrompts()which will set a callback in the server to ask the application to provide the prompt details for the client.