Uh oh!
There was an error while loading. Please reload this page.
fix(runner): resolve unresolved review feedback on write anchoring and local review scope - #22
Merged
Merged
Conversation
…d local review scope Addresses the unresolved Greptile threads from PRs #2, #7, #16, and #19: - packages/runner: fail closed when /proc/self/fd is unavailable instead of renaming through a re-resolved mutable pathname (PR #16 thread). - packages/runner: range-less local reviews now include index-only changes and untracked files in both the changed-file list and the diff context (PR #19 thread). - packages/agent: planned writes are restricted to the files the validated finding cites; review-diff membership alone no longer authorizes a write (PR #19 thread). - .env.example: drop AGENT_ZERO_PORT, which referenced the removed Nitro server (PR #2 threads). - PR #7 thread (hook workflow docs) is already covered by CONTRIBUTING.md. Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…ntracked content Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
…ate patches Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
…vive Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
The Nitro control plane is being restored in #24 and honors this variable, so dropping it as a leftover of the removed server no longer applies.
Uh oh!
There was an error while loading. Please reload this page.
…ff once Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
… markers Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
…location Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
…test Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the unresolved Greptile review threads left on merged PRs #2, #7, #16, and #19.
Fallback directory anchor could be redirected outside the checkout (#16,
packages/runner/src/boundary.ts). When/proc/self/fdis unavailable, the old fallback verified the parent directory's inode and then returned its mutable pathname, so a concurrent rename-to-symlink after the comparison could redirect the commit rename outside the checkout. Node exposes no descriptor-relative create/rename, so the write now fails closed:A new test drives the write path through a dead descriptor and asserts the write is refused and the target untouched. Reads are unaffected; on platforms without
/proc/self/fdthe runner is effectively read-only, which matches the repository's fail-closed safety posture.Local proactive review omitted pending changes (#19,
packages/runner/src/boundary.ts). A range-less review ran a plaingit diff, which ignores index-only changes and untracked files.reviewFilesnow unionsgit diff --name-only --cached,git diff --name-only, andgit ls-files --others --exclude-standard. The range-lesscontextdiff is a single consolidatedgit diff HEADpatch (one final-state block per file, so a partially-staged edit never surfaces its intermediate staged value as a separate patch), plus a syntheticgit diff --no-index /dev/null <path>creation patch for each untracked file so their content reaches the reviewer; a repository without commits falls back to the staged and working-tree layers. Pull-request base/head ranges keep the previous fixed-range behavior.Autofix scope exceeded the validated finding (#19,
packages/agent/src/agent.ts).scopeChangesunionedfinding.fileswithinput.files, so on proactive runs every file in the review diff was writable even when the accepted finding and its evidence cited only one. The scope is now the validated finding's cited files only; changes to other review-diff files are refused toneeds-human, with a regression test.Leftovers from #2 and #7. The #2 threads target the Nitro server, which #21 removed and #24 restores with the routes registered and
AGENT_ZERO_PORThonored, so.env.examplekeeps that entry. The #7 thread (git-hook workflow documentation) is already satisfied by the current CONTRIBUTING.md "Style and commits" section; no change needed.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is enabled.Confidence Score: 5/5
No blocking failure remains.
Executed repository scenarios confirm the updated review context behaves correctly for the exercised local-change workflows.
What T-Rex did
Reviews (10): Last reviewed commit: "fix(runner): render omitted review patch..." | Re-trigger Greptile