Skip to content

fix: drop unused vitest>vite pnpm overrides - #73

Merged
RedStar071 merged 5 commits into
mainfrom
fix/pnpm-overrides
Sep 6, 2026
Merged

fix: drop unused vitest>vite pnpm overrides#73
RedStar071 merged 5 commits into
mainfrom
fix/pnpm-overrides

Conversation

@RedStar071

@RedStar071RedStar071 commented Sep 4, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

N/A — small maintenance fix, no tracking issue.

🧭 Context

pnpm-workspace.yaml pinned vitest>vite and @vitest/mocker>vite to 6.4.3 via overrides, with a comment explaining Vite 8/oxc doesn't support the experimental decorator transform vitest needs. That pin is redundant: vitest@4.1.11's own peer range already resolves vite to 6.4.3 without any override.

📚 Description

  • Removed the overrides block (and its comment) from pnpm-workspace.yaml.
  • Regenerated pnpm-lock.yaml via pnpm install and confirmed vite still resolves to 6.4.3 everywhere.

Key changes

FileChange
pnpm-workspace.yamlRemoved unused vitest>vite / @vitest/mocker>vite overrides
pnpm-lock.yamlRegenerated (resolved versions unchanged)

Note: open Renovate PRs #28 (@vitest/mocker>vite → v8) and #29 (vitest>vite → v8) target this override — they'll need re-evaluating once this merges, since bumping past vite@6 still breaks the decorator transform per the removed comment.

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Workflow / CI change

Pre-flight Checklist

  • I have read the Contributing Guidelines (if applicable)
  • My code follows the code style of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have updated the documentation accordingly
  • I added a changeset with pnpm changeset (or pnpm changeset add --empty if no release is needed). See .changeset/README.md. — not applicable, no publishable package changed.

Confidence Score: 4/5

This change is non-blocking for the committed lockfile, but it is not safe for future clean dependency resolution until the Vite 6 constraint is restored.

One verified non-security P2 finding is present, and there are no P0 or P1 findings.

Files Needing Attention: pnpm-workspace.yaml

T-Rex T-Rex Logs

What T-Rex did

  • T-Rex produced a proof for the posted P2 finding and linked it to the review comment that describes the finding.
  • An experiment was run to study how Vite resolves overrides, with results captured for comparison.
  • I inspected the Vite 6 decorator test result to confirm the test ran and produced output.
  • I inspected the Vite 8 decorator test failure and captured the failure details for review.
  • I generated an override comparison output that summarizes differences between the tested configurations.

View all artifacts

T-Rex Ran code and verified through T-Rex

Fix all with GreploopFix All in Claude CodeFix All in CursorFix All in Cursor Cloud Agents

Prompt To Fix All With AI
### Issue 1
pnpm-workspace.yaml:6
**Preserve Vite constraint**
Removing the Vitest Vite overrides allows a clean dependency resolution to select Vite 8.2.2 instead of Vite 6.4.3. The decorator-dependent subcommands test then fails before collection because Vite 8 uses Oxc, which ignores the configured esbuild decorator transform and produces a syntax error. Keep the explicit Vite 6 overrides until the decorator tests support newer Vite versions. This is non-blocking today because the committed lockfile still resolves Vite 6, but future lockfile regeneration or dependency updates will break the test suite.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "fix: drop unused vitest>vite pnpm overri..." | Re-trigger Greptile

Greptile also left 1 inline comment on this PR.

vitest@4.1.11's peer range still resolves vite to 6.4.3 without
pinning it via pnpm-workspace.yaml overrides, so the override is
redundant. Confirmed the resolved version is unchanged after
regenerating the lockfile.
Comment threadpnpm-workspace.yaml
@pkg-pr-new

pkg-pr-newBot commented Sep 6, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/@wolfstar/plugin-api@73
pnpm add https://pkg.pr.new/@wolfstar/plugin-i18next@73
pnpm add https://pkg.pr.new/@wolfstar/plugin-logger@73
pnpm add https://pkg.pr.new/@wolfstar/plugin-subcommands-advanced@73

commit: a3c676c

@lorypellilorypelli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RedStar071
RedStar071 merged commit bd26653 into mainSep 6, 2026
15 checks passed
@RedStar071
RedStar071 deleted the fix/pnpm-overrides branch September 6, 2026 18:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@RedStar071@lorypelli