Skip to content

Limit predictive text override to Samsung keyboard - #1027

Merged
nbradbury merged 1 commit into
trunkfrom
issue/limit-samsung-predictive-text-fix-to-samsung-keyboard
Jan 31, 2023
Merged

Limit predictive text override to Samsung keyboard#1027
nbradbury merged 1 commit into
trunkfrom
issue/limit-samsung-predictive-text-fix-to-samsung-keyboard

Conversation

@khaykov

Copy link
Copy Markdown
Contributor

This PR restricts the fix introduced in #1024 to Samsung keyboards only. Since other keyboards actually work ok, this fix can limit their functionality.

I also changed the API level fix targeting to an open ended >= 33 since we do not know when or if it's going to be fixed.

Test (Using Samsung device running Android 13)

  1. Make sure default Samsung keyboard is installed on your device.
  2. Open the demo app and tap in the editor (this will initialize the Input Connection between keyboard and editor).
  3. Check logcat and confirm that you see the Overriding predictive text behavior on Samsung device with Samsung Keyboard with API 33 message.
  4. Install any other keyboard (eg. Gboard, Swift Keyboard)
  5. Open tap app and tap in the editor.
  6. Confirm that the log message from step 3 is not visible.

Voila.

@khaykov
khaykov marked this pull request as ready for review January 30, 2023 22:21
@nbradburynbradbury self-assigned this Jan 31, 2023

@nbradburynbradbury left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is good! :shipit:

@nbradbury
nbradbury merged commit 3aa28e0 into trunkJan 31, 2023
@nbradbury
nbradbury deleted the issue/limit-samsung-predictive-text-fix-to-samsung-keyboard branch January 31, 2023 11:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@khaykov@nbradbury