Uh oh!
There was an error while loading. Please reload this page.
Add text size modifier - #1061
Merged
Merged
Conversation
nbradbury
approved these changes
Sep 28, 2023
nbradbury
left a comment
Contributor
There was a problem hiding this comment.
All good, thanks for this change! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a text size modifier, that is applied to base font size, and scales all the text accordingly. This is mainly aimed at use cases where you have specific heading sizes defined, instead of relying on default scaling behavior.
If you don't have a manually set heading sizes, all the text will scale with base font size.
Modifier can be negative, for downscaling.
To test:
Try setting the modifier using
setTextSizeModifier(egvisualEditor.setTextSizeModifier(25)) and confirm that the text scales as expected.Try settings custom heading font sized using
headingOneFontSize,headingTwoFontSize, etc. Confirm that heading size is scaling properly.If there are new strings that have to be translated, I have added them to the client's
strings.xmlas a part of the integration PR.