Uh oh!
There was an error while loading. Please reload this page.
Improve Mark formatting - #1073
Conversation
…ing color customization
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…is no longer active
geriux
commented
Mar 18, 2024
Hey there @antonis 👋 I was wondering if you would be able to help me out with a PR review 😄, I've updated the Highlight color implementation so it fixes some issues for this feature since we first partially implemented it in #943 A lot of testing has been already done in WordPress/gutenberg#57650 so I was wondering if you'd have some time to check the native code for the Aztec side. Let me know if you could take a look! Thank you! |
antonis
commented
Mar 19, 2024
I'll be glad to help with this @geriux :) I plan to get to this later today or tomorrow 🙇 |
geriux
commented
Mar 19, 2024
Thank you so much! |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…es changes to how new values are set
Related PRs:
This PR adds missing implementation for the Mark formatting style.
MarkPluginthat will handle adding the needed CSS attributes.MarkSpanto receive a color param and to set it as the current color.applyMarkInlineStylein favor ofapplyAfterMarkInlineStylewhich will handle if the color changes while editing a Mark span.Test
Please follow the testing instructions in this PR's description.
This shouldn't affect other Aztec functionalities.
Make sure strings will be translated:
strings.xmlas a part of the integration PR.