Skip to content

[Fix] Update targetSdk to 34 from 33. - #1074

Merged
irfano merged 2 commits into
trunkfrom
fix/target-sdk-34-update
Jan 25, 2024
Merged

[Fix] Update targetSdk to 34 from 33.#1074
irfano merged 2 commits into
trunkfrom
fix/target-sdk-34-update

Conversation

@notandyvee

@notandyveenotandyvee commented Jan 23, 2024

Copy link
Copy Markdown
Contributor

Fix

Issue: #1072
Related: wordpress-mobile/gutenberg-mobile#6533.

This PR bumps the targetSdk version from 33 to 34. It depends on WP Utils 141: wordpress-mobile/WordPress-Utils-Android#141

Test

  • Ensure build passes.
  • Ensure the sample app is showing rich text properly.

Review

@irfano

Note

I'm not 100% sure how to test this against WP-util, other than waiting until that one is merged and then updating it here. Thoughts @ravishanker

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@notandyvee

Copy link
Copy Markdown
ContributorAuthor

Looks like there are build issues. Will fix.

@irfano

Copy link
Copy Markdown
Member

I tested and confirmed targetSdk upgrade works. 👍🏻
UI tests are failing because Robolectric added Android support with 4.11, and we are currently using 4.9. If you wish, you can upgrade the Robolectric version in a separate PR by targeting fix/target-sdk-34-update to distinguish the context from this PR.

@notandyvee

Copy link
Copy Markdown
ContributorAuthor

Done @irfano . Thanks!

@irfanoirfano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@irfano
irfano merged commit 1aa0a85 into trunkJan 25, 2024
@irfano
irfano deleted the fix/target-sdk-34-update branch January 25, 2024 15:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@notandyvee@irfano