Skip to content

Remove redundant context from AztecDynamicImageSpan - #1087

Merged
zwarm merged 5 commits into
trunkfrom
issue/remove-redundant-context-form-image-span
Jul 22, 2024
Merged

Remove redundant context from AztecDynamicImageSpan#1087
zwarm merged 5 commits into
trunkfrom
issue/remove-redundant-context-form-image-span

Conversation

@khaykov

@khaykovkhaykov commented Jul 19, 2024

Copy link
Copy Markdown
Contributor

Fix

It looks like the context in AztecDynamicImageSpan was never used, but we still pass it from all the spans that are based on AztecDynamicImageSpan. This is a vector for memory leaks, so I'm removing it.

Test

  1. Make sure the app builds, and all the spans look normal.
  2. Make sure the changes make sense.

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@zwarmzwarm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find @khaykov 👏

I tested according to instructions, as well as two devices side-by-side (this branch and trunk). No differences in behavior. 👍

@zwarm
zwarm merged commit db247eb into trunkJul 22, 2024
@zwarm
zwarm deleted the issue/remove-redundant-context-form-image-span branch July 22, 2024 21:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@khaykov@zwarm