Uh oh!
There was an error while loading. Please reload this page.
Improve thread safety of AztecAttributes - #1100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#705
We sometimes get issue with in AztecAttributes, that hint at some sort of data corruption, and I was able to syntetically cause crashes with multi threaded overloading.
In this PR we ensure that only one thread can operate on the attributes at any given time, thereby preventing race conditions and ensuring data consistency during concurrent operations.
There is not much to test, just make sure the demo app and client side implementation are working.
Review
@[USER_NAME]
Make sure strings will be translated:
strings.xmlas a part of the integration PR.