Uh oh!
There was an error while loading. Please reload this page.
Improve behaviour of Compose Placeholder manager - #1103
Merged
planarvoid merged 2 commits intoApr 28, 2025
Conversation
planarvoid
deleted the
issue/improve-behaviour-of-compose-placeholder-manager
branch
April 28, 2025 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
In this PR I'm fixing behaviour of the compose placeholder manager when handling changes to a placeholder that don't change the placeholder size. For example switching order of photos in a gallery. To achieve this I've added
equalsimplementation toAztecAttributes. I'm using this to determine of a placeholder has changed and should be redrawn.Test
Test this with the linked DayOne PR