Skip to content

Fix: apply boundary checks on span start and end range#1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Twinsen81 merged 1 commit into from
Aug 4, 2025
Merged

Fix: apply boundary checks on span start and end range #1108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions aztec/src/main/kotlin/org/wordpress/aztec/util/SpanWrapper.kt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,6 +36,16 @@ class SpanWrapper<T>(var spannable: Spannable, var span: T) {
set(flags) { setSpanOrLogError(span, start, end, flags) }

private fun setSpanOrLogError(span: T, start: Int, end: Int, flags: Int) {
if (start < 0 || end < 0) {
AppLog.w(AppLog.T.EDITOR, "span starts/ends before 0")
return
}

if (end < start) {
AppLog.w(AppLog.T.EDITOR, "span end is before start")
return
}

// Silently ignore invalid PARAGRAPH spans that don't start or end at paragraph boundary
if (isInvalidParagraph(spannable, start, end, flags)) return

Expand Down