Skip to content

Revert "Make AztecAttributes immutable in order to stop crashes" - #759

Merged
malinajirka merged 1 commit into
developfrom
revert-751-make_aztec_attributes_immutable
Nov 8, 2018
Merged

Revert "Make AztecAttributes immutable in order to stop crashes"#759
malinajirka merged 1 commit into
developfrom
revert-751-make_aztec_attributes_immutable

Conversation

@mzorz

@mzorzmzorz commented Nov 7, 2018

Copy link
Copy Markdown
Contributor

Reverts #751

Note: should be ok, used the GH option to create this revert PR 👍
Note 2: any reviewer will do, no need to have all 3 reviewers, just requested to make sure any of you give it the go 😄

@malinajirka

Copy link
Copy Markdown
Contributor

Thanks!! LGTM.

@planarvoidplanarvoid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@malinajirka
malinajirka merged commit 8b30f79 into developNov 8, 2018
@malinajirka
malinajirka deleted the revert-751-make_aztec_attributes_immutable branch November 8, 2018 10:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mzorz@malinajirka@planarvoid