Uh oh!
There was an error while loading. Please reload this page.
Feature: Add support for the mark HTML tag - #939
Merged
Conversation
0nko
commented
Oct 7, 2021
Contributor
@geriux I can't merge the PR. |
geriux
commented
Oct 7, 2021
Author
I can't either 😅 I'll investigate it, thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
This PR adds support for the
markHTML tag.It currently supports setting the text color and there are plans to add support for background-color as well.
Test
Review
@0nko
Make sure strings will be translated:
strings.xmlas a part of the integration PR.